vdk-dag: fix unnecessary authorization failure #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have locally configured authorizaton settings (e.g client id, refresh token and so on) which might be expired or wrong, VDK dag still tries to authenticate and generate access token even if no authentication may be required by the Control Service API. This casues the DAG jobs to fail with authentication error which is unnecssary if the API didn't require auth. Instead we now just post a warning about the failure to get acess token. We fail later if and only if the API requires authentication . If not everything suceeeds. Testing Done: local tests pass (they failed before for above reason) Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
duyguHsnHsn
approved these changes
Feb 8, 2024
DeltaMichael
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have locally configured authorizaton settings (e.g client id, refresh token and so on) which might be expired or wrong, VDK dag still tries to authenticate and generate access token even if no authentication may be required by the Control Service API. This casues the DAG jobs to fail with authentication error which is unnecssary if the API didn't require auth.
Instead we now just post a warning about the failure to get acess token. We fail later if and only if the API requires authentication . If not everything suceeeds.
Testing Done: local tests pass (they failed before for above reason)