Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control-service: optimize job builder pip install #3151

Merged
merged 1 commit into from
Feb 21, 2024
Merged

control-service: optimize job builder pip install #3151

merged 1 commit into from
Feb 21, 2024

Conversation

antoniivanov
Copy link
Collaborator

Pip caching is never useful for Docker builds, and it makes the image bigger and cause the process to consume more memory which can lead to OOM errors.

@antoniivanov
control-service: optimize job builder pip install
a96a2cd 
Pip caching is never useful for Docker builds, and it makes the image
bigger and cause the process to consume more memory which can lead to
OOM errors.
@murphp15
Copy link
Collaborator

Brilliant!
Does that make this ticket (#3142) redundant ?

@mivanov1988 mivanov1988 enabled auto-merge (squash) February 21, 2024 14:15
@murphp15
Copy link
Collaborator

Previously I needed the below to build pytorch.
Do you know roughly how much memory it will save?

  --set deploymentBuilderResourcesDefault.limits.memory=36000Mi \
  --set deploymentBuilderResourcesDefault.requests.memory=28000Mi \
  --set deploymentBuilderResourcesDefault.limits.cpu=5 \
  --set deploymentBuilderResourcesDefault.requests.cpu=3 \

@antoniivanov
Copy link
Collaborator Author

Brilliant! Does that make this ticket (#3142) redundant ?

I haven't verified it is enough so no for now. But it should help

@antoniivanov antoniivanov mentioned this pull request Feb 21, 2024
Closed
@antoniivanov antoniivanov merged commit 6d21c29 into main Feb 21, 2024
13 checks passed
@antoniivanov antoniivanov deleted the person/aivanov/cs branch February 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mivanov1988 mivanov1988 mivanov1988 approved these changes

@murphp15 murphp15 murphp15 approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antoniivanov @murphp15 @mivanov1988 @vmwclabot