vdk-dag: improve error handling and error messages #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielgeorgiev1
approved these changes
Feb 21, 2024
duyguHsnHsn
approved these changes
Feb 22, 2024
To make it easier to debug VDK DAG jobs some improvements in error handling are done. - Stop using deprecated UserCodeError in favour of domain oriented exceptoin class - Improve the formatting of the error message in case of failure. Testing Done: existing tests for regression. Here is a comparison before and now in the formatting: https://gist.githubusercontent.com/antoniivanov/8f87cdef1c610fcd24361197bcba45dc/raw/c31b990de2c0b1f49ac5989419cfc6ab12aac934/gistfile1.txt
for more information, see https://pre-commit.ci
To make it easier to debug VDK DAG jobs some improvements in error handling are done. - Stop using deprecated UserCodeError in favour of domain oriented exceptoin class - Improve the formatting of the error message in case of failure. Testing Done: existing tests for regression. Here is a comparison before and now in the formatting: https://gist.githubusercontent.com/antoniivanov/8f87cdef1c610fcd24361197bcba45dc/raw/c31b990de2c0b1f49ac5989419cfc6ab12aac934/gistfile1.txt
antoniivanov
force-pushed
the
person/aivanov/vdk-dag
branch
from
2cc6078
to
1048644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to debug VDK DAG jobs some improvements in error handling are done.
Testing Done: existing tests for regression.
Here is a comparison before and now in the formatting: https://gist.githubusercontent.com/antoniivanov/8f87cdef1c610fcd24361197bcba45dc/raw/c31b990de2c0b1f49ac5989419cfc6ab12aac934/gistfile1.txt