Bugfix for: File picker is not working for virtual UNC directories + improvements #13
Conversation
…Node for simplicity and improved debuging
…ory has another directories but no files children. We don't need to filter directories which don't contain files because better is to show empty directory without expand arrow next to them. Aditional StringSplitOptions.RemoveEmptyEntries flag used and simplicity filter checking.
…e, so we can rename FolderTreeControler to more consistency name FilePickerTreeController
wtct
changed the title
|
Hi, As you can see from the dates, I haven't worked on this repo for a looong time. I'm currently not active in the Umbraco community and don't have time to work on this. I invited you to become a contributor on this project. This way you can merge the changes yourself and perhaps re-publish the package |
|
Hi, Thanks a lot for your answer! So I need to make decision now but please tell me if I can create a new package based on this package because I did a lot of modifications which have large influence on it. What about licence should I mention about primary owner? I want to set new package name and maybe transfer this to Umbraco 8 in the future. |
|
As far as I'm concerned, you decide! If you attribute me as original source/inspiration, that would be nice. |
Thanks! If I find more time I create new package and mention you and your package as inspiration. Otherwhise I merge this changes. |
…ted with paths, MapPath optimization)
Hi!
It is very helpful package but file picker is unfortunately not working for UNC virtual directories. When you try to expand any folder then error occurs that specified path can't be found. It is caused by replacing double backslash with slash in wrong order.
I think that there is another bug which disallows to expand folder which contains only directories when any filter is applied.
I need package like this so I decided not to duplicate this package but to improve this one so I prepared special pull request with bug fixes and overal package improvements.
Unfortunately in my opinion the logic and code had poor quality. It is very simple package but it was very difficult to understand the logic due to lack of variables naming consistency. The same problem was with path and virtual path deriving methods. There was a lot duplicated operations for folder and file tree nodes.
I hope you will anjoy my pull request and merge it.
Best!