Skip to content

Commit

Permalink
feat: add github pull-request template (#7)
Browse files Browse the repository at this point in the history
  • Loading branch information
lamngockhuong authored Jun 8, 2024
1 parent db205e1 commit 38e3f58
Showing 1 changed file with 44 additions and 0 deletions.
44 changes: 44 additions & 0 deletions .github/pull-request-template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<!--
Put easy title to understand.
Don't forget to set reviewers and assignees.
-->

# Pull Request types
<!-- Choose only something to come under. -->

- 🐛 Bug Fix
- 👍 Improvement
- ✨ New Feature
- 🎉 Release
- ♻️ Refactoring
- 🚿 Refactoring (Remove functions)
- 💚 Refactoring (Test or CI)
- 👕 Fix (Lint)
- 🆙 Update (Dependency packages)
- 🚀 Improvement (Performance)
- 👮 Improvement (Security)
- 🔒 Restriction (Restrict new feature)
- 👾 Others

# Description
<!-- Write detailed explanations, URL of explanatory materials, Issue ticket, etc -->

# Checklist
<!-- Write review checklist for dev and reviewer -->

- [ ] 1. Build successfully on local
- [ ] 2. Format all code files included in the PR
- [ ] 3. No more unconfirmed specs in the PR
- [ ] 4. Tested the normal case and error cases following specs
- [ ] 5. Is there a refactor to the old code? If yes, have you tested the old function and noted the impact yet?
- [ ] 6. Loops have a set length and correct termination conditions
- [ ] 7. There aren't any redundant or duplicate codes in PR (clean code)
- [ ] 8. There aren't any hard-coded in the code in PR
- [ ] 9. Optimization logic handling and optimizations SQL (for example, don't get redundant data or add an index to optimize performance, query only necessary fields...)
- [ ] 10. Update issue status and add PR link to the issue

# Evidence
(Screenshot or Video)

# Discussion
<!-- Write what you want to check, what you don't have to check, etc. -->

0 comments on commit 38e3f58

Please sign in to comment.