-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add programmatical support for downloading source code back #93
Conversation
Should return the url directly instead of download it everytime |
should? You shouldn't bridge an API endpoint directly to user. |
Then, shouldn't it show right in details? |
The details panel is under reconstruction. Including it in is useless nevertheless. This PR is mainly for adding a feature - not polishing it. |
Then the feature is not completed, thus, is not approved. |
Okay, back to the definition of completed - you want me to implement a feature, including debugging it, that I'll definitely throw the implementation away after 48-to-72h in place for a new one? No, thank you. I don't want my effort to be wasted. And even though we have deadline ourselves, our software isn't as important as the Linux kernel to require a thing called backports. Something is better than nothing, and the details panel can now be considered a wasted effort. I'll not throw another thing into the void, because even though
What's the connection between linking a blob directly and the place to put the link on the interface? You probably misunderstood somewhere - an endpoint shouldn't be directly linked to the user, and that's it. It does not matter where I have to put it - in a And let me state this again : this PR is one in two prerequisites for work on #70 to be initiated. The reason is not that I'm afraid of merge conflicts, but the consequences of it - merge conflicts mean that you have to resolve them by hand, which means, you have to re-write some stuff. And bugs come bundled with code - I will not attempt to debug a snippet that will replace another already tested snippet. It is a matter of sensible time and energy usage, not that I am lazy to do |
The problem is not that you'll eventually throw code away, but you've assumed lots of things before deciding to code. When implementing, you didn't even ask for the design and just write your thought out without thinking. At least, you can google the design first. I know the UI/UX design can be hard, but it's not okay to keep secret yourself and work on it alone. |
Fine. This feature will be hidden instead - since you decided not to have it in the table and I don't want to throw my effort into the void, for now, consider the feature a hidden easter egg or something like that - where do I put them anyway? It exists, but not enabled - and that's it. |
Consider this PR to add skeletal things instead of implementing a fully working solution. |
Using prettier.config.js
Rewriting submission details panel
Closes #76.
Note that #86 will be abandoned due to introduced bug.
EDIT : this PR merely adds the required implementations. It does not propose an UI design.