Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add programmatical support for downloading source code back #93

Merged
merged 17 commits into from
Mar 23, 2019

Conversation

minhducsun2002
Copy link
Contributor

@minhducsun2002 minhducsun2002 commented Mar 16, 2019

Closes #76.

Note that #86 will be abandoned due to introduced bug.

EDIT : this PR merely adds the required implementations. It does not propose an UI design.

@minhducsun2002 minhducsun2002 added the enhancement New feature or request label Mar 16, 2019
@minhducsun2002 minhducsun2002 self-assigned this Mar 16, 2019
@dungwinux
Copy link
Member

Should return the url directly instead of download it everytime

@minhducsun2002
Copy link
Contributor Author

should? You shouldn't bridge an API endpoint directly to user.

@dungwinux
Copy link
Member

Then, shouldn't it show right in details?

@minhducsun2002
Copy link
Contributor Author

The details panel is under reconstruction. Including it in is useless nevertheless.

This PR is mainly for adding a feature - not polishing it.

@dungwinux
Copy link
Member

Then the feature is not completed, thus, is not approved.

@minhducsun2002
Copy link
Contributor Author

minhducsun2002 commented Mar 17, 2019

Then the feature is not completed, thus, is not approved.

Okay, back to the definition of completed - you want me to implement a feature, including debugging it, that I'll definitely throw the implementation away after 48-to-72h in place for a new one? No, thank you. I don't want my effort to be wasted.

And even though we have deadline ourselves, our software isn't as important as the Linux kernel to require a thing called backports.

Something is better than nothing, and the details panel can now be considered a wasted effort. I'll not throw another thing into the void, because even though git reset exists for code, there is nothing like that for the time I've put into it .

Then, shouldn't it show right in details?

What's the connection between linking a blob directly and the place to put the link on the interface? You probably misunderstood somewhere - an endpoint shouldn't be directly linked to the user, and that's it. It does not matter where I have to put it - in a <div> with onClick, a <a>, a <Button>, or whatever.


And let me state this again : this PR is one in two prerequisites for work on #70 to be initiated. The reason is not that I'm afraid of merge conflicts, but the consequences of it - merge conflicts mean that you have to resolve them by hand, which means, you have to re-write some stuff. And bugs come bundled with code - I will not attempt to debug a snippet that will replace another already tested snippet.

It is a matter of sensible time and energy usage, not that I am lazy to do git commit after git merge.

@dungwinux
Copy link
Member

The problem is not that you'll eventually throw code away, but you've assumed lots of things before deciding to code. When implementing, you didn't even ask for the design and just write your thought out without thinking. At least, you can google the design first. I know the UI/UX design can be hard, but it's not okay to keep secret yourself and work on it alone.
Plus, the deadline can be extended, as long as you're able to finish the work in the right way. Don't argue me that you have to git reset because you did it without thinking.

@minhducsun2002
Copy link
Contributor Author

Fine. This feature will be hidden instead - since you decided not to have it in the table and I don't want to throw my effort into the void, for now, consider the feature a hidden easter egg or something like that - where do I put them anyway? It exists, but not enabled - and that's it.

@minhducsun2002
Copy link
Contributor Author

Consider this PR to add skeletal things instead of implementing a fully working solution.

@minhducsun2002 minhducsun2002 changed the title Allow downloading source code back Add support for downloading source code back Mar 17, 2019
@minhducsun2002 minhducsun2002 changed the title Add support for downloading source code back Add programmatical support for downloading source code back Mar 18, 2019
@minhducsun2002 minhducsun2002 merged commit f36e92f into master Mar 23, 2019
@minhducsun2002 minhducsun2002 deleted the source-download branch March 23, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants