Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce non empty chainID on node app init #1234

Merged
merged 1 commit into from
Jan 9, 2024
Merged

enforce non empty chainID on node app init #1234

merged 1 commit into from
Jan 9, 2024

Conversation

jordipainan
Copy link
Member

closes #1224

@jordipainan jordipainan requested review from p4u and altergui January 9, 2024 09:57
@coveralls
Copy link

coveralls commented Jan 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7459511365

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 62.082%
Totals Coverage Status
Change from base Build 7408910288: -0.2%
Covered Lines: 14814
Relevant Lines: 23862
💛 - Coveralls

@jordipainan jordipainan merged commit 55148b7 into main Jan 9, 2024
19 checks passed
@jordipainan jordipainan deleted the fix/1224 branch January 9, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4u p4u p4u approved these changes

@altergui altergui Awaiting requested review from altergui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: chainID must be enforced at APP level
3 participants
@jordipainan @coveralls @p4u