Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and makefile step for clang++ -Weverything with necessary fixes. #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matu3ba
Copy link

@matu3ba matu3ba commented Dec 6, 2024

This also adds a workaround to the object hack due to missing .hpp

…fixes.

This also adds a workaround to the object hack due to missing .hpp
@matu3ba
Copy link
Author

matu3ba commented Dec 6, 2024

Please tell me the necessary .clang-format changes, if you want to change them and/or other changes you feel would be necessary.

@matu3ba matu3ba mentioned this pull request Dec 6, 2024
@vog
Copy link
Owner

vog commented Dec 9, 2024

Thanks a lot for your contribution. Alas, in its current form it is pretty hard to review.

Could you please split your pull request into two separate pull requests?

  • The first request would be fore for pure formatting changes.
    • It would add the .clang-format, which in its current form is fine for me.
    • It would contain only white-space changes (indentation, breaking lines differently, etc.).
  • The second pull request, as a follow-up to the first one, would contain the actual code changes.
    • It would contain the Makefile changes to add the compiler flags.
    • It would contain the code changes to fix the compiler warning.

Alternatively, you could skip the reformatting entirely and provide a pull request with only code and Makefile changes, leaving the current coding style intact.

Again, thanks so far!

@vog
Copy link
Owner

vog commented Dec 9, 2024

This also adds a workaround to the object hack due to missing .hpp

That change might also warrant a separate pull request, or at least a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants