Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to claim other freegames from GOG #206

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

4n4n4s
Copy link
Contributor

@4n4n4s 4n4n4s commented Sep 10, 2023

I added an option to claim free games from GOG. There is like 50ish of them like https://www.gog.com/en/game/crusader_kings_ii.

Therefore I added new flags for it this is disabled by default as we just claim the giveaway games.

You can enable it by adding and additional flag and can specify many other filters like for game categories or preferred language.

@4n4n4s
Copy link
Contributor Author

4n4n4s commented Sep 16, 2023

@vogler can you maybe check and give feedback?

@yoshimo
Copy link

yoshimo commented Sep 16, 2023

don't remove the handling of the trusted partner setting.

Copy link
Owner

@vogler vogler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. I'll try to test it tomorrow and then merge it with the changes.

@@ -0,0 +1,19 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I want to add vscode configurations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it's maybe good to have it if someone uses codespaces to fix something quickly

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gog.js Outdated Show resolved Hide resolved
- additional checks for freegames for filters
- cleanup file
- updated README
@4n4n4s 4n4n4s requested a review from vogler September 24, 2023 16:30
@4n4n4s
Copy link
Contributor Author

4n4n4s commented Oct 3, 2023

Thanks! Looks good. I'll try to test it tomorrow and then merge it with the changes.

Hi how did it go?
Would be cool to have some of the PRs merged before I can continue with some refactoring some of the things. thx 👍

@yoshimo
Copy link

yoshimo commented Oct 3, 2023

Shouldn't we have the option for more than one url so we can combine

https://www.gog.com/en/games?priceRange=0,0&hideOwned=true&onlyDlcForOwned=true
https://www.gog.com/en/games?priceRange=0,0&hideOwned=true&hideDLCs=true

in one run?

@4n4n4s
Copy link
Contributor Author

4n4n4s commented Oct 3, 2023

Shouldn't we have the option for more than one url so we can combine


https://www.gog.com/en/games?priceRange=0,0&hideOwned=true&onlyDlcForOwned=true

https://www.gog.com/en/games?priceRange=0,0&hideOwned=true&hideDLCs=true

in one run?

Good idea should not be a problem to have a delimiter here like ";" or " " and then run trough them in a loop.
I will add it.

- you can specify downloads for games and also dls for owned games etc
@4n4n4s
Copy link
Contributor Author

4n4n4s commented Oct 11, 2023

@vogler sorry I am impatient :) Will you be able to give feedback for my open PRs soon?

Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants