Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authenticate against Tableau on every API call #12

Merged
merged 4 commits into from
Dec 29, 2022

Conversation

fernandobrito
Copy link
Collaborator

@fernandobrito fernandobrito commented Dec 29, 2022

https://voidev.atlassian.net/browse/DATAPS-1199

From time to time, we started to get connection errors when running this automation internally.

image

We have changed how we manage the sessions when using the tableauserverclient, and now the issue is gone.

I thought this would have performance implications since we have a loop retrieving details for workbooks, but it barely made a difference.

@codecov-commenter
Copy link

Codecov Report

Base: 84.97% // Head: 83.96% // Decreases project coverage by -1.01% ⚠️

Coverage data is based on head (a91fed0) compared to base (b40d7c0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   84.97%   83.96%   -1.02%     
==========================================
  Files           8        8              
  Lines         233      237       +4     
  Branches       31       36       +5     
==========================================
+ Hits          198      199       +1     
- Misses         27       30       +3     
  Partials        8        8              
Impacted Files Coverage Δ
src/exposurescrawler/crawlers/tableau.py 89.55% <ø> (-0.16%) ⬇️
src/exposurescrawler/tableau/rest_client.py 45.00% <0.00%> (-10.56%) ⬇️
src/exposurescrawler/dbt/exposure.py 100.00% <0.00%> (ø)
src/exposurescrawler/tableau/models.py 100.00% <0.00%> (ø)
src/exposurescrawler/tableau/graphql_client.py 78.33% <0.00%> (+0.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fernandobrito fernandobrito merged commit b49ae4f into main Dec 29, 2022
@fernandobrito fernandobrito deleted the authenticate-more-often branch December 29, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants