Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore personal spaces #9

Merged
merged 3 commits into from
May 2, 2022
Merged

fix: ignore personal spaces #9

merged 3 commits into from
May 2, 2022

Conversation

ritikasri23
Copy link
Contributor

This is to fix the automation to ignore workbooks that are created under personal spaces.

Copy link
Collaborator

@fernandobrito fernandobrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov-commenter
Copy link

Codecov Report

Merging #9 (5054139) into main (592b820) will decrease coverage by 0.73%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   85.71%   84.97%   -0.74%     
==========================================
  Files           8        8              
  Lines         231      233       +2     
  Branches       30       31       +1     
==========================================
  Hits          198      198              
- Misses         26       27       +1     
- Partials        7        8       +1     
Impacted Files Coverage Δ
src/exposurescrawler/crawlers/tableau.py 89.70% <0.00%> (-2.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592b820...5054139. Read the comment docs.

@@ -18,6 +18,12 @@


def _should_ignore_workbook(workbook, projects_to_ignore: Collection[str]) -> bool:
# Personal spaces are usually used as a sandbox for experimental work

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a test for this.
We do have some tests in this repo, but I think we can improve.
Let me know if you would like to do it together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinneville I merged this PR. I guess your comment was added after the merge. We can do it together sometime soon. :)

@fernandobrito
Copy link
Collaborator

Good point. +1 on adding tests, either in this PR or in a subsequent one so the incident is resolved.

@ritikasri23 ritikasri23 merged commit 9b5de7e into main May 2, 2022
@ritikasri23 ritikasri23 deleted the ignore-personal-spaces branch May 2, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants