-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore personal spaces #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 85.71% 84.97% -0.74%
==========================================
Files 8 8
Lines 231 233 +2
Branches 30 31 +1
==========================================
Hits 198 198
- Misses 26 27 +1
- Partials 7 8 +1
Continue to review full report at Codecov.
|
@@ -18,6 +18,12 @@ | |||
|
|||
|
|||
def _should_ignore_workbook(workbook, projects_to_ignore: Collection[str]) -> bool: | |||
# Personal spaces are usually used as a sandbox for experimental work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add a test for this.
We do have some tests in this repo, but I think we can improve.
Let me know if you would like to do it together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinneville I merged this PR. I guess your comment was added after the merge. We can do it together sometime soon. :)
Good point. +1 on adding tests, either in this PR or in a subsequent one so the incident is resolved. |
This is to fix the automation to ignore workbooks that are created under
personal spaces
.