Skip to content
This repository has been archived by the owner on Feb 5, 2025. It is now read-only.

fix: Random fixes (DSN-000) #309

Merged
merged 15 commits into from
Nov 14, 2024
Merged

Conversation

mikaalnaik
Copy link
Contributor

Fixes or implements VF-XXX

Brief description. What is this change?

Implementation details. How do you make this change?

Setup information

Deployment Notes

Related PRs

Checklist

  • Breaking changes have been communicated, including:
    • New required environment variables
    • Renaming of interfaces (API routes, request/response interface, etc)
  • New environment variables have been deployed
  • Appropriate tests have been written
    • Bug fixes are accompanied by an updated or new test
    • New features are accompanied by a new test

@mikaalnaik mikaalnaik self-assigned this Nov 13, 2024
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 3:23pm

Copy link

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Comment on lines +95 to 98
{feedback && !isLast && (
<div className={feedbackContainer({ isLast: false })}>
<FeedbackButton {...feedback} variant={FeedbackButtonVariant.PREVIOUS_RESPONSE} />
</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes feedback functionality for the last response. To preserve the original behavior, consider using:

{feedback && (
  <div className={feedbackContainer({ isLast })}>
    <FeedbackButton
      {...feedback}
      variant={isLast ? FeedbackButtonVariant.LAST_RESPONSE : FeedbackButtonVariant.PREVIOUS_RESPONSE}
    />
  </div>
)}

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@mikaalnaik mikaalnaik changed the title fix: conditional render (DSN-000) fix: Random fixes (DSN-000) Nov 14, 2024
@mikaalnaik mikaalnaik merged commit e8cdd6e into master Nov 14, 2024
11 checks passed
@mikaalnaik mikaalnaik deleted the mikaal/feedback-fix-sigh/DSN-000 branch November 14, 2024 19:39
ChidiNweze pushed a commit to ChidiNweze/react-chat that referenced this pull request Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants