Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): complete removal of ckpts in colab #581

Merged
merged 7 commits into from
May 6, 2023
Merged

Conversation

Meldoner
Copy link
Contributor

@Meldoner Meldoner commented May 6, 2023

The file that is about to be deleted is overwritten with a size of 0 bytes, this prevents trash overflow in google drive
Closes #474

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.03 🎉

Comparison is base (f79de0c) 19.73% compared to head (097ef72) 19.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   19.73%   19.77%   +0.03%     
==========================================
  Files          39       39              
  Lines        3379     3383       +4     
  Branches      463      464       +1     
==========================================
+ Hits          667      669       +2     
- Misses       2695     2697       +2     
  Partials       17       17              
Impacted Files Coverage Δ
src/so_vits_svc_fork/utils.py 22.26% <50.00%> (+0.47%) ⬆️
src/so_vits_svc_fork/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/so_vits_svc_fork/utils.py Show resolved Hide resolved
src/so_vits_svc_fork/utils.py Outdated Show resolved Hide resolved
src/so_vits_svc_fork/utils.py Outdated Show resolved Hide resolved
src/so_vits_svc_fork/utils.py Outdated Show resolved Hide resolved
Meldoner and others added 6 commits May 6, 2023 16:08
Co-authored-by: 34j <55338215+34j@users.noreply.github.com>
Co-authored-by: 34j <55338215+34j@users.noreply.github.com>
Co-authored-by: 34j <55338215+34j@users.noreply.github.com>
Co-authored-by: 34j <55338215+34j@users.noreply.github.com>
@Meldoner Meldoner requested a review from 34j May 6, 2023 13:32
@34j 34j merged commit e8964c6 into voicepaw:main May 6, 2023
@34j
Copy link
Collaborator

34j commented May 6, 2023

@allcontributors add Meldoner ideas, code

@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @Meldoner! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old ckpts are not completely deleted in colab
3 participants