Add initial support for @ subvolumes for BTRFS partitions #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool.. |
hervyqa
reviewed
May 1, 2022
installer.sh.in
Outdated
| # Setup subvolume on BTRFS partitions | ||
| echo "Mounting $dev on $mntpt ($fstype) to create subvolume @..." >$LOG | ||
| mount -t $fstype $dev $TARGETDIR >$LOG 2>&1 | ||
| btrfs subvolume create $TARGETDIR/@ >$LOG 2>&1 |
There was a problem hiding this comment.
This is cool. But, how about setting multi subvolume like @home and @snapshot? does btrfs just create @ subvolume enough?
classabbyamp
added
the
installer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick modification to the installer script that automatically creates
@subvolumes on BTRFS partitions. I mentioned in my issue (#205) thatzstdcompression could (and should) be enabled for better performance ifzstdwas part ofbase-voidstrap. So, if this change was made, this might not be the final version.