Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: update to 5.3.1. #53191

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bryanasdev000
Copy link

Testing the changes

  • I tested the changes in this PR: Testing...

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

Notes

Still testing, specifically for https://blog.podman.io/2024/10/podman-5-3-changes-for-improved-networking-experience-with-pasta/ (in my case, container/app to host/db)

Tests for Quadlet (probably because systemd?) are not passing.

@bryanasdev000 bryanasdev000 marked this pull request as draft November 22, 2024 19:15
@Anachron
Copy link
Contributor

podman 5.3.1 was able to build cleanly here on both x86_64 and x86_64-musl.
I've also compiled it for aarch64 and will test it now on my NAS.

@bryanasdev000
Copy link
Author

podman 5.3.1 was able to build cleanly here on both x86_64 and x86_64-musl. I've also compiled it for aarch64 and will test it now on my NAS.

Will bump to 5.3.1 and test it here too.

Currently running rootless podman with connections from container to host ok

@bryanasdev000
Copy link
Author

As expected, tests are failing at the same point on 5.3.1.

Also, not sure if this logs are relevant:

grep: Perl matching not supported in a --disable-perl-regexp build
...
make[1]: Leaving directory '/builddir/podman-5.3.1/test/tools'
/usr/bin/bash: line 1: git: command not found

@Anachron
Copy link
Contributor

That git: command not found message claims git is missing from hostmakedepends.

I am not sure why you or github would receive this error but my local builds are fine?

@bryanasdev000 bryanasdev000 changed the title podman: update to 5.3.0. podman: update to 5.3.1. Nov 25, 2024
@bryanasdev000
Copy link
Author

That git: command not found message claims git is missing from hostmakedepends.

I am not sure why you or github would receive this error but my local builds are fine?

It complete without issues, but is something that print a few times on the build log.

Will add it to see what changes.

@classabbyamp
Copy link
Member

adding git to hostmakedepends isn't correct. first, it's only used during check, so it would be checkdepends, but in this case putting PATH=/usr/libexec/chroot-git:${PATH}" in the template is probably enough

@bryanasdev000
Copy link
Author

adding git to hostmakedepends isn't correct. first, it's only used during check, so it would be checkdepends, but in this case putting PATH=/usr/libexec/chroot-git:${PATH}" in the template is probably enough

Put this on do_check() ?

do_check() {
        export PATH=/usr/libexec/chroot-git:${PATH}"
        make .install.ginkgo
        make localunit
}

@bryanasdev000
Copy link
Author

Oh, gotcha an example on ardour.

@bryanasdev000
Copy link
Author

Well, adding git revels another error:

=> podman-5.3.1_1: running do_check ...
removed 'cmd/quadlet/main_test.go'
make -C test/tools build/ginkgo
make[1]: Entering directory '/builddir/podman-5.3.1/test/tools'
make[1]: 'build/ginkgo' is up to date.
make[1]: Leaving directory '/builddir/podman-5.3.1/test/tools'
fatal: not a git repository (or any of the parent directories): .git

Trying to ignore the quadlet test as it is the only one failing, messing with ginkgo but its ignoring my flags (although it prints that is using it).

So far, if I delete cmd/quadlet/main_test.go I can finish the tests ok, but I am not sure if this dirt way is approved.

I am also testing this:

diff --git a/srcpkgs/podman/template b/srcpkgs/podman/template
index 0f7c8940ed3..73eff02509c 100644
--- a/srcpkgs/podman/template
+++ b/srcpkgs/podman/template
@@ -20,6 +20,7 @@ distfiles="https://github.com/containers/podman/archive/v${version}.tar.gz"
 checksum=5b4e9ddce69cc2c8c8b8529e90093ae3ea9cb2959e2fceb98469b282dbffbcc7

 export PATH="/usr/libexec/chroot-git:$PATH"
+export TESTFLAGS="--skip-package quadlet --skip-file quadlet"

 if [ "$CROSS_BUILD" ]; then
        go_build_tags+=" containers_image_openpgp"
@@ -35,6 +36,8 @@ post_build() {
 }

 do_check() {
+       rm -v cmd/quadlet/main_test.go
        make .install.ginkgo
        make localunit
 }

But like I said, ginkgo still parses and execute the quadlet test.

@bryanasdev000
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants