Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console email backend to properly omit attachments #43

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

codingjoe
Copy link
Member

@codingjoe codingjoe commented Jul 20, 2023

Since we now render templates later, the test falsely passed.
Now we actually remove it from the message payload and display the number of omitted payloads.

@codingjoe codingjoe self-assigned this Jul 20, 2023
@codingjoe codingjoe requested a review from amureki July 20, 2023 15:35
Copy link
Member

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing this! 🙌

@codingjoe codingjoe merged commit a19ee41 into main Jul 20, 2023
13 checks passed
@codingjoe codingjoe deleted the fit-console branch July 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants