Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subdomain redirects in tracking logic #50

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Conversation

amureki
Copy link
Member

@amureki amureki commented Jul 27, 2023

No description provided.

@amureki amureki self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c9b14e) 100.00% compared to head (fb60715) 100.00%.

❗ Current head fb60715 differs from pull request most recent head 3a52fc0. Consider uploading reports for the commit 3a52fc0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          346       353    +7     
=========================================
+ Hits           346       353    +7     
Files Changed Coverage Δ
emark/views.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amureki amureki force-pushed the allow-subdomain-redirects branch 4 times, most recently from 7a54622 to a741aec Compare July 27, 2023 15:35
@amureki
Copy link
Member Author

amureki commented Jul 27, 2023

@codingjoe would be great if you could check it and if everything is fine - then release/deploy.

@amureki amureki requested a review from herrbenesch July 28, 2023 08:56
Copy link
Contributor

@herrbenesch herrbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@amureki amureki merged commit f6b6d71 into main Jul 28, 2023
13 checks passed
@amureki amureki deleted the allow-subdomain-redirects branch July 28, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants