Fix connection issues #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 10 +1
Lines 355 360 +5
=========================================
+ Hits 355 360 +5
☔ View full report in Codecov by Sentry. |
codingjoe
commented
Jul 28, 2023
codingjoe
force-pushed
the
fix-tracking
branch
3 times, most recently
from
1362620
to
49e2a02
Compare
Render markdown emails before opening a SMTP connection to avoid connection timeouts. Services like AWS SES have very short connection timeouts. Therefore, all messages should be fully rendered before a connection is established.
amureki
requested changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render markdown emails before opening a SMTP connection to avoid
connection timeouts. Services like AWS SES have very short
connection timeouts. Therefore, all messages should be fully
rendered before a connection is established.