Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #54 -- Reset existing payloads only (#55) #55

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

amureki
Copy link
Member

@amureki amureki commented Aug 22, 2023

No description provided.

@amureki amureki added the bug Something isn't working label Aug 22, 2023
@amureki amureki self-assigned this Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b74e368) 99.72% compared to head (dc6ef1e) 99.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          10       10           
  Lines         367      368    +1     
=======================================
+ Hits          366      367    +1     
  Misses          1        1           
Files Changed Coverage Δ
emark/backends.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@codingjoe codingjoe changed the title Fix #54 -- reset payload only when exists Fix #54 -- Reset existing payloads only (#55) Aug 22, 2023
@codingjoe codingjoe merged commit b45538e into main Aug 22, 2023
15 checks passed
@codingjoe codingjoe deleted the 54/empty-payload branch August 22, 2023 19:07
amureki added a commit that referenced this pull request Sep 25, 2023
amureki added a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants