Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin hard Voila #85

Merged
merged 9 commits into from
Jul 20, 2023
Merged

Pin hard Voila #85

merged 9 commits into from
Jul 20, 2023

Conversation

martinRenou
Copy link
Member

Voici does not work with Voila 0.5.0a5.

Let's make a patch release that pins it. I will try to come up with a PR that brings support for it.

@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@martinRenou martinRenou added the bug Something isn't working label Jul 17, 2023
@jtpio
Copy link
Member

jtpio commented Jul 17, 2023

What is it that makes it not work? The JupyterLab 4 update?

@martinRenou
Copy link
Member Author

Probably yes. Though we cannot update Voici to JupyterLab 4 because of JupyterLite.

It's probably also just due to the voila template changes in this PR.

@martinRenou martinRenou marked this pull request as draft July 17, 2023 09:44
@martinRenou
Copy link
Member Author

There are multiple issues resulting in the CI to fail on master:

  • pandas >=2.0 is broken on emscripten-forge (need @atrawog's help on this)
  • latest jupyterlab_widgets build is incompatible with what Voici uses. This is not possible to fix unless we rebuild Voici with that latest version -> trying this results in having multiple versions of Lumino (v1 and v2) and JupyterLab packages (v3 and v4) and the build fails. This is because jupyterlite needs JupyterLab v3, and for some reason yarn's dedupe does not work.
    I think the only solution here would be to pin jupyterlab_widgets and ipywidgets in the emscripten-forge environment (in jupyterlite-xeus-python?)
  • latest Voila build is against JupyterLab 4, which is not possible to use because of jupyterlite -> we need to pin Voila

@martinRenou
Copy link
Member Author

update playwright snapshots

@martinRenou martinRenou marked this pull request as ready for review July 20, 2023 12:13
@martinRenou martinRenou merged commit 429caa5 into voila-dashboards:main Jul 20, 2023
4 checks passed
@martinRenou martinRenou deleted the pin_voila branch July 20, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants