Small clean up and solves #150 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
reviewed
Nov 2, 2021
binder/environment.yml
Outdated
| @@ -10,5 +10,5 @@ dependencies: | |||
| - pandas | |||
| - scipy | |||
| - voila | |||
| - voila-gridstack=0.2.0 | |||
| - jupyterlab=3 | |||
| - voila-gridstack | |||
There was a problem hiding this comment.
Maybe we could remove voila-gridstack from the environment.yml? And add pip install . in a postBuild file.
That way we could more easily test PRs on Binder.
jtpio
reviewed
Nov 2, 2021
|
This can be tested on Binder: https://mybinder.org/v2/gh/hbcarlos/voila-gridstack/vg-scroll?urlpath=lab/tree/examples |
|
Thanks, Jeremy! |
|
Just checking: it sounded like the issue mentioned in #122 (comment) is not related to this PR? Then we can track it separately to not block the merge. |
|
No, is not related to this PR. Also is not critical, and I don't think users will see this issue since it happens when stopping and running JupyterLab several times. |
This was
linked to
issues
Nov 2, 2021
Closed
|
I'll resume #148 so we can release this change and the other ones that were merged recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves multiple issues.
Commits:
1: Removes versions from the binder env file to install latest.
2: Solve #143
* Remaining comments from #142.
3: Solves #150:
* Adds the scrolled distance to the y offset.
4 and 6: Improves the size of a new cell
* When adding a new cell to the grid, the size is too small.
* Gets the size from the original cell and adds 40px to the height (the size of the toolbar).
5 and 8: Makes the grid fit the size of the panel
* Once the grid is rendered, gets the size of the panel and modifies the
min-heightof the grid to fit the panel.* I think this improves the UX by having always the grid visible, and removing the resize behavior when adding the first cell to the grid.
* This doesn't affect the final look of the layout when rendering with voila.
* Problem: we don't have the helper anymore (Maybe I can add it on top).
9: Improves the scroll behavior
* Remove the horizontal scroll since is not necessary.
* Allows scrolling when adding a new cell.
Screencast:
Peek.2021-11-01.10-20.mp4