-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jupyterlab GridStack #69
Conversation
Upgrade to the Lab 3 extension system
Merge develop into master
Temp pin jupyterlab_server in setup.py
Remove jupyter lab build step from binder
Update to JupyterLab 3.0.0rc0
Update to TypeScript 4
How about naming the JupyterLab Extension We know have the Similarly, we could rename |
43f86b5
to
fd719a4
Compare
acb9f77
to
89a316f
Compare
'ipykernel', | ||
'jupyter_server~=1.0.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sticking to this for now since a recent version of jupyter_server
changed the names of some pytest fixtures.
2d77aa3
to
6e07595
Compare
6e07595
to
e675923
Compare
After a fresh install in a new environment: $ jupyter labextension list
JupyterLab v3.0.0rc13
/home/jtp/miniforge3/envs/test/share/jupyter/labextensions
@jupyter-widgets/jupyterlab-manager v3.0.0-alpha.2 enabled OK
@voila-dashboards/jupyterlab-gridstack v0.1.0 enabled OK (python, voila-gridstack)
This comes from the |
base_develop_cmd = cmdclass['develop'] | ||
|
||
|
||
class DevelopCmd(base_develop_cmd): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be a better way to handle this, so the symlinks to the template files are correctly created in development mode.
cc @hbcarlos @SylvainCorlay if you want to check it out. This should be ready to go. voila-gridstack/packages/jupyterlab-gridstack/package.json Lines 74 to 83 in 27a8402
Just opened #70 to track the remaining item:
|
Just tried and works perfectly. Thanks Jeremy! |
The last commit updates to the latest JupyterLab 3.0 final packages. We should be able to merge this PR, and proceed with a release soon. |
Opened #72 to track this. |
Add the
jupyterlab-gridstack
extension from https://github.com/hbcarlos/voila-editorTODO
outputDir
tovoila-gridstack/labextension
setup.py
is still correct after the switch tojupyter-packaging
@voila-dashboards/jupyterlab-gridstack
Update to the latest-> tracked in Update the tests to work with the latest jupyter server #70jupyter_server.pytest_plugin