Feat support py files via jupytext #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
reviewed
Jul 29, 2019
| @@ -16,7 +16,7 @@ | |||
| # if the directory above us contains the following paths, it means we are installed in dev mode (pip install -e .) | |||
| DEV_MODE = os.path.exists(os.path.join(ROOT, '../setup.py')) and os.path.exists(os.path.join(ROOT, '../share')) | |||
|
|
|||
| notebook_path_regex = r'(.*\.ipynb)' | |||
| notebook_path_regex = r'(.*\.(?:ipynb|py))' | |||
There was a problem hiding this comment.
Wondering if we could get support for other languages for free here (Julia, R and so on)?
There was a problem hiding this comment.
Indeed, I've added julia in #330, because I could test it. I didn't feel comfortable adding more. I also wonder if we should have a .* regex?
There was a problem hiding this comment.
This regex was added because voila could only handle .ipynb files.
But if scripts (in different languages) are going to be supported, it probably make sense to switch back to .*. Otherwise we would have to maintain a white list of supported extensions.
|
My preference now is to rely on #330 (merge that PR, close this PR), and document that you can use jupytext instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly solves #107 because jupytext works with jupyter server out of the box, so we can do:
And it just works.
For voila standalone support we just have to wait for #270 and get this for free.
If we don't want to wait for this we could add cmd line option to voila to force it to use jupytext, e.g.:
Another option would be to support py files natively out of the box (I'll do a separate PR for that).