Upgrade Torch to 1.13.X #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iceychris
commented
Jul 20, 2023
•
iceychris
commented
- test on Android
- test on iOS (requires setting extra ld flags in downstream project? => nope 😅)
- document PyTorch version divergence (Android vs. iOS) in commit message
iceychris
force-pushed
the
upgrade-pytorch
branch
from
4c696d5 to
d033e76
Compare
Legion2
requested changes
Aug 10, 2023
Note: with this commit, the underlying Torch versions diverge depending on OS: - On Android, pytorch_android_lite 1.13.1 is used - On iOS, LibTorch 1.13.0 (cocoapods release 1.13.0.1) is used
iceychris
force-pushed
the
upgrade-pytorch
branch
from
d033e76 to
365f61a
Compare
Legion2
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.