Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.2] Fix ${var} string interpolation deprecation #181

Merged
merged 1 commit into from
Aug 10, 2022
Merged

[PHP 8.2] Fix ${var} string interpolation deprecation #181

merged 1 commit into from
Aug 10, 2022

Conversation

Ayesh
Copy link
Contributor

@Ayesh Ayesh commented Jun 19, 2022 •
edited by voku
Loading

PHP 8.2 deprecates "${var}" string interpolation pattern.
This fixes all 8 of such occurrences in voku/portable-utf8 package.

This change is Reviewable

@Ayesh
[PHP 8.2] Fix ${var} string interpolation deprecation
4dbf919 
PHP 8.2 deprecates `"${var}"` string interpolation pattern.
This fixes all 8 of such occurrences in `voku/portable-utf8` package.

 - [PHP 8.2: `${var}` string interpolation deprecated](https://php.watch/versions/8.2/${var}-string-interpolation-deprecated)
 - [RFC](https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation)
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
66.7% 66.7% Duplication

@mitelg
Copy link

mitelg commented Jun 21, 2022

thank you @Ayesh 👍

I just set up a PHP 8.2 pipeline for our project and this was the only issue so far on our side and I was about to do the same as you 😁

@cpeel cpeel mentioned this pull request Jul 10, 2022
Merged
@coveralls
Copy link

coveralls commented Jul 16, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 79.408% when pulling 4dbf919 on Ayesh:php82/dollar-var-deprecation into 6b501e2 on voku:master.

@codecov
Copy link

codecov bot commented Jul 16, 2022 •
edited
Loading

Codecov Report

Merging #181 (4dbf919) into master (6b501e2) will not change coverage.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##             master     #181   +/-   ##
=========================================
  Coverage     81.34%   81.34%           
  Complexity     1766     1766           
=========================================
  Files             2        2           
  Lines          3950     3950           
=========================================
  Hits           3213     3213           
  Misses          737      737
Impacted Files Coverage Δ
src/voku/helper/UTF8.php 81.37% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b501e2...4dbf919. Read the comment docs.

@staabm
Copy link

staabm commented Jul 23, 2022

just came here to report the same thing ;-).

@staabm staabm mentioned this pull request Aug 8, 2022
Merged
@staabm
Copy link

staabm commented Aug 10, 2022

@voku anything we can do so this PR can be merged?

@voku voku merged commit a66bc9a into voku:master Aug 10, 2022
@voku
Copy link
Owner

voku commented Aug 10, 2022

Thanks, @Ayesh and sorry for the delay. I will tag a new version.

@patrickomeara patrickomeara mentioned this pull request Dec 19, 2022
Merged
@ReLater ReLater mentioned this pull request Dec 28, 2022
Closed
@laoneo laoneo mentioned this pull request Jan 12, 2023
Open
@majermi4 majermi4 mentioned this pull request Feb 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ayesh @mitelg @coveralls @staabm @voku