Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Config languages and services keys required #109

Closed
wants to merge 1 commit into from

Conversation

remcohaszing
Copy link
Member

This provides a slightly more convenient interface for server plugins. The default is defined with a null prototype, so it doesn’t have predefined keys.

For example, this allows for the following change in the MDX language server:

- config.languages ||= {}
  config.languages.mdx = getLanguageModule(plugins)
- config.services ||= {}
  config.services.markdown = createMarkdownService()
  config.services.typescript = createTypeScriptService(modules.typescript)

This provides a slightly more convenient interface for server plugins.
The default is defined with a null prototype, so it doesn’t have
predefined keys.
@johnsoncodehk
Copy link
Member

Closed because since #113, the language server no longer supports the default config file. thanks!

@remcohaszing remcohaszing deleted the required-config-keys branch December 19, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants