refactor(langauge-server): Improve LSP diagnostic integration #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
provideSemanticDiagnosticshook, LanguageServicePlugin should prompt thatprovideDiagnosticsneeds to be recalculated when other files change throughcapabilities.diagnosticProvider.interFileDependencies = true.The
pullModelDiagnosticsoption has been removed. Volar will maintain its own logic to determine whether to enable pull model: when the language client supports pull diagnostics and no LanguageServicePlugin enablesinterFileDependencies, pull diagnostics will be used. Otherwise use push diagnostics. The reason is that according to the summary in Add options to only sync visible documents to the server microsoft/vscode-languageserver-node#848 (comment), the pull model is currently not reliable enough.