Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(source-map): updated API section based on #207 #248

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

alamhubb
Copy link
Contributor

@alamhubb alamhubb commented Nov 18, 2024

Hello, I'm trying to develop a custom syntax lsp plugin based on ts recently, using volar.js, which is really great, saving me a lot of work and letting me learn a lot.

I'm learning about the functions of the code mapping related parts, and I found that the document description in

https://github.com/volarjs/volar.js/blob/master/packages/source-map/README.md

and the code implementation in

https://github.com/volarjs/volar.js/blob/master/packages/source-map/lib/sourceMap.ts are inconsistent, so I tried to synchronize this document

@johnsoncodehk johnsoncodehk changed the title Updated @volar/source-map/README based on PR(#207) docs(source-map): updated API section based on #207 Dec 13, 2024
@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 960b838 into volarjs:master Dec 13, 2024
4 checks passed
Copy link

pkg-pr-new bot commented Dec 13, 2024

Open in Stackblitz

@volar/eslint

npm i https://pkg.pr.new/volarjs/volar.js/@volar/eslint@248

@volar/jsdelivr

npm i https://pkg.pr.new/volarjs/volar.js/@volar/jsdelivr@248

@volar/language-core

npm i https://pkg.pr.new/volarjs/volar.js/@volar/language-core@248

@volar/kit

npm i https://pkg.pr.new/volarjs/volar.js/@volar/kit@248

@volar/language-server

npm i https://pkg.pr.new/volarjs/volar.js/@volar/language-server@248

@volar/language-service

npm i https://pkg.pr.new/volarjs/volar.js/@volar/language-service@248

@volar/monaco

npm i https://pkg.pr.new/volarjs/volar.js/@volar/monaco@248

@volar/source-map

npm i https://pkg.pr.new/volarjs/volar.js/@volar/source-map@248

@volar/test-utils

npm i https://pkg.pr.new/volarjs/volar.js/@volar/test-utils@248

@volar/typescript

npm i https://pkg.pr.new/volarjs/volar.js/@volar/typescript@248

@volar/vscode

npm i https://pkg.pr.new/volarjs/volar.js/@volar/vscode@248

commit: 9bba29e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants