Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(language-core): only synchronize the source file currently needed #89

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

johnsoncodehk
Copy link
Member

FileProvider can no longer access all virtual files, as this requires implementing a synchronized function that updates all project source files. Instead, the upper layer should loop through its list of source files and request virtual files from the FileProvider one by one.

The advantage of this is that the synchronization function drops from O(n) to O(1).

@johnsoncodehk johnsoncodehk merged commit a1cb105 into master Nov 19, 2023
6 checks passed
@johnsoncodehk johnsoncodehk deleted the o1-sync branch November 19, 2023 11:00
@johnsoncodehk johnsoncodehk mentioned this pull request Nov 21, 2023
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant