Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify file path display #3

Closed
johnsoncodehk opened this issue Jun 30, 2023 · 1 comment
Closed

Simplify file path display #3

johnsoncodehk opened this issue Jun 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@johnsoncodehk
Copy link
Member

Currently file path includes the full information of the uri, which besides being redundant, causes typescript to try to execute fs requests from directories that don't even exist.

螢幕截圖 2023-06-30 下午8 06 40
@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Jun 30, 2023
@johnsoncodehk johnsoncodehk changed the title Simplified file path display Simplify file path display Jul 1, 2023
@johnsoncodehk
Copy link
Member Author

This should be resolved in createUriConverter. If the scheme and authority of the parsed URI are the same as the root folder, the scheme and authority are hidden in fileName.

johnsoncodehk added a commit to volarjs/volar.js that referenced this issue Jul 2, 2024
@johnsoncodehk
feat(language-server): simplify asFileName result if possible
8ada673 
close volarjs/vscode-typescript-web#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnsoncodehk