Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new state SchGated #131

Closed

Conversation

ykcai-daniel
Copy link

To support Pod Scheduling Readiness, we need to add new state to api. For more detail, see proposal volcano-sh/volcano#3581

Signed-off-by: ykcai-daniel <1155141377@link.cuhk.edu.hk>
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ykcai-daniel
Copy link
Author

Previously, we introduced a new state to decouple scheduling gated jobs from inqueued jobs and ensure correct computation of inqueued resources without modifying plugins.

We have changed the design of pod scheduling gates. Since the main motivation is to ensure compatibility with K8S, we want to minimize change to existing api and implementations, therefore we no longer make change to the states in scheduler. Instead, we make changes to the plugins to make sure the inqueued resource is calculated correctly when there are scheduling gated tasks. More details in volcano-sh/volcano#3658.

@Monokaix
Copy link
Member

That's a good idea!

@Monokaix
Copy link
Member

/close

@volcano-sh-bot
Copy link
Collaborator

@Monokaix: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants