fix: keep updating task's min available number same as creating podgroup

Signed-off-by: lowang_bh <lhui_wang@163.com>
volcano-sh · Apr 23, 2023 · d797380 · d797380
1 parent 86ff941
commit d797380
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/pkg/controllers/job/job_controller_actions.go b/pkg/controllers/job/job_controller_actions.go
@@ -718,20 +718,21 @@ func (cc *jobcontroller) createOrUpdatePodGroup(job *batch.Job) error {
 	}
 
 	for _, task := range job.Spec.Tasks {
-		if task.MinAvailable == nil {
-			continue
+		cnt := task.Replicas
+		if task.MinAvailable != nil {
+			cnt = *task.MinAvailable
 		}
 
 		if taskMember, ok := pg.Spec.MinTaskMember[task.Name]; !ok {
 			pgShouldUpdate = true
-			pg.Spec.MinTaskMember[task.Name] = *task.MinAvailable
+			pg.Spec.MinTaskMember[task.Name] = cnt
 		} else {
-			if taskMember == *task.MinAvailable {
+			if taskMember == cnt {
 				continue
 			}
 
 			pgShouldUpdate = true
-			pg.Spec.MinTaskMember[task.Name] = *task.MinAvailable
+			pg.Spec.MinTaskMember[task.Name] = cnt
 		}
 	}