Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics exposure for volcano scheduling start time and end time for each job #2312

Closed
dontan001 opened this issue Jun 27, 2022 · 10 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dontan001
Copy link
Contributor

What would you like to be added:

Currently we find there are no metrics to indicate the scheduling start time and end time for each job, and only scheduling duration is available, which is e2e_job_scheduling_duration.

We would like these two timestamps could be exposed in Volcano, there after could be visualized via Grafana annotation in dashboard, and it is a great help when we are doing the Spark+Volcano performance analysis

Why is this needed:

It is for spark+volcano performance analysis

@dontan001 dontan001 added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2022
@dontan001
Copy link
Contributor Author

Please help take a look @william-wang @hwdef @Thor-wl , I can help raise a PR for this if there is chance

@hwdef
Copy link
Member

hwdef commented Jun 27, 2022

I think this is useful.
And we already added start and end time in job condition.

@william-wang
Copy link
Member

@dontan001 That's reasonable to have start time and end time of the job. Go ahead to raise a PR :)

@hwdef
Copy link
Member

hwdef commented Jun 27, 2022

ref: #1764

@dontan001
Copy link
Contributor Author

Thank you @hwdef for sharing the PR
I did a quick check and seems the conditions are updated for CR vcjobs in the above PR, while in our case we are using native spark-submit directly

Let me prepare a PR then please comment further, thanks very much for the update @hwdef @william-wang

@Thor-wl
Copy link
Contributor

Thor-wl commented Jun 27, 2022

@dontan001 That's reasonable to have start time and end time of the job. Go ahead to raise a PR :)

+1. It makes sense.

@dontan001
Copy link
Contributor Author

Please review and let me know if any suggestion, thanks a lot

@dontan001
Copy link
Contributor Author

Considering the kube-state-metrics may not be deployed in user environment, it would be brilliant to expose the start time in Volcano as well.

I have refined the PR to include both, please review again when get chance @hwdef @william-wang @Thor-wl

@Thor-wl
Copy link
Contributor

Thor-wl commented Jul 5, 2022

/close

@volcano-sh-bot
Copy link
Contributor

@Thor-wl: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants