Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event Handler for RS to GC Podgroup. New Solution to Fix Issue 2143 #2585

Closed
RamezesDong opened this issue Nov 29, 2022 · 6 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@RamezesDong
Copy link

What would you like to be added:

For issue #2143 when deployment update, it will create new replicaset and volcano controller will create new podgroup for replicaset. After several times update, the Deployment has many Inqueue podgroups. A new solution that is different from Enhance Generate PodGroup OwnerReferences for Normal Pod, add an event handler for rs to gc podgroup when rs' replicas set to zero.

Why is this needed:

One solution to this problem is #2151 , which change the ownerReference of podgroup from rs to deployment. We develop a hack version of this solution, but some problems still exist. When deployment's replicas are set to zero, the podgroup has alive still! So, this solution is incomplete and ugly to design.

Overall, We think that it is the clear and easy-to-understand solution to add event handler for rs.

@RamezesDong RamezesDong added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2022
@stale
Copy link

stale bot commented Mar 18, 2023

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2023
@wangyang0616
Copy link
Member

wangyang0616 commented Mar 24, 2023

associate #2667

Issue fixed, close

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 24, 2023
@wangyang0616
Copy link
Member

/close

@volcano-sh-bot
Copy link
Contributor

@wangyang0616: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bysph
Copy link

bysph commented Nov 29, 2023

@RamezesDong Hello, I noticed that the newly created pod group phase will be "Completed" after this modification(originally "Running"). Is this expected behavior?

@bysph
Copy link

bysph commented Nov 29, 2023

@RamezesDong Hello, I noticed that the newly created pod group phase will be "Completed" after this modification(originally "Running"). Is this expected behavior?

This will effect the result of e2e test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants