-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Event Handler for RS to GC Podgroup. New Solution to Fix Issue 2143 #2585
Comments
Hello 👋 Looks like there was no activity on this issue for last 90 days. |
associate #2667 Issue fixed, close |
/close |
@wangyang0616: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@RamezesDong Hello, I noticed that the newly created pod group phase will be "Completed" after this modification(originally "Running"). Is this expected behavior? |
This will effect the result of e2e test case |
What would you like to be added:
For issue #2143 when deployment update, it will create new replicaset and volcano controller will create new podgroup for replicaset. After several times update, the Deployment has many Inqueue podgroups. A new solution that is different from Enhance Generate PodGroup OwnerReferences for Normal Pod, add an event handler for rs to
gc
podgroup when rs' replicas set to zero.Why is this needed:
One solution to this problem is #2151 , which change the
ownerReference
of podgroup from rs to deployment. We develop a hack version of this solution, but some problems still exist. When deployment's replicas are set to zero, the podgroup has alive still! So, this solution is incomplete and ugly to design.Overall, We think that it is the clear and easy-to-understand solution to add event handler for rs.
The text was updated successfully, but these errors were encountered: