Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #121]fix state convert #126

Merged
merged 1 commit into from
May 7, 2019
Merged

Conversation

wangyuqing4
Copy link
Contributor

No description provided.

@wangyuqing4 wangyuqing4 force-pushed the state branch 2 times, most recently from 0fa8167 to 74032e2 Compare May 5, 2019 10:01
@TommyLike
Copy link
Contributor

@wangyuqing4 It's very rare to see all of the testcases failing, please ensure this change works correctly for CREATE/RESTART/SUSPEND/RESUME actions, and if that so, I would like to work on updating these testcases to reflect the latest state machine of Job Resource.

cc @k82cn

@wangyuqing4 wangyuqing4 force-pushed the state branch 4 times, most recently from 38e5068 to 8314ba4 Compare May 6, 2019 05:56
@k82cn
Copy link
Member

k82cn commented May 7, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 7, 2019
@volcano-sh-bot volcano-sh-bot merged commit b9ea8d5 into volcano-sh:master May 7, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants