Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Webhook Clean #2109

Closed

Conversation

whybeyoung
Copy link
Contributor

Fix issue2102
Signed-off-by: maybaby ybyang7@iflytek.com

Signed-off-by: maybaby <ybyang7@iflytek.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wpeng102
You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 23, 2022
Signed-off-by: maybaby <ybyang7@iflytek.com>
Signed-off-by: maybaby <ybyang7@iflytek.com>
Signed-off-by: maybaby <ybyang7@iflytek.com>
@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2022
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not possible to modify yaml directly. These yamls are generated

@whybeyoung
Copy link
Contributor Author

It is not possible to modify yaml directly. These yamls are generated

ok , not very familiar with that, where the code you mentioned? thanks

@hwdef
Copy link
Member

hwdef commented Mar 23, 2022

https://github.com/volcano-sh/volcano/tree/master/installer/helm/chart/volcano

Modify files in this folder, and run make update-development-yaml

}
if service.MutatingConfig != nil {
for i := range service.MutatingConfig.Webhooks {
service.MutatingConfig.Webhooks[i].SideEffects = &sideEffect
service.MutatingConfig.Webhooks[i].AdmissionReviewVersions = reviewVersions
service.MutatingConfig.Webhooks[i].ClientConfig = clientConfig
}

// fix webhook name pattern whether use service or url
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// fix webhook name pattern whether use service or url
// fix webhook name pattern whether use service or url

@whybeyoung
Copy link
Contributor Author

whybeyoung commented Mar 24, 2022

https://github.com/volcano-sh/volcano/tree/master/installer/helm/chart/volcano

Modify files in this folder, and run make update-development-yaml

@hwdef can you build in your env?

make generate-yaml TAG=latest RELEASE_DIR=installer
mkdir -p _output/bin
mkdir -p installer
/Users/yangyanbo/projects/cetc-cloud/go_project/bin/controller-gen "crd:crdVersions=v1,generateEmbeddedObjectMeta=true" paths="./vendor/volcano.sh/apis/pkg/apis/scheduling/v1beta1;./vendor/volcano.sh/apis/pkg/apis/batch/v1alpha1;./vendor/volcano.sh/apis/pkg/apis/bus/v1alpha1;./vendor/volcano.sh/apis/pkg/apis/nodeinfo/v1alpha1" output:crd:artifacts:config=config/crd/bases
Error: unable to parse option "crd:crdVersions=v1,generateEmbeddedObjectMeta=true": [unknown argument "generateEmbeddedObjectMeta" (at <input>:1:42) extra arguments provided: "true" (at <input>:1:43)]
Usage:
  controller-gen [flags]

Examples:
        # Generate RBAC manifests and crds for all types under apis/,
        # outputting crds to /tmp/crds and everything else to stdout
        controller-gen rbac:roleName=<role name> crd paths=./apis/... output:crd:dir=/tmp/crds output:stdout

@stale
Copy link

stale bot commented May 25, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2022
@Thor-wl Thor-wl removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2022
@stale stale bot closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants