-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Webhook Clean #2109
fix: Fix Webhook Clean #2109
Conversation
Signed-off-by: maybaby <ybyang7@iflytek.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: maybaby <ybyang7@iflytek.com>
Signed-off-by: maybaby <ybyang7@iflytek.com>
Signed-off-by: maybaby <ybyang7@iflytek.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not possible to modify yaml directly. These yamls are generated
ok , not very familiar with that, where the code you mentioned? thanks |
https://github.com/volcano-sh/volcano/tree/master/installer/helm/chart/volcano Modify files in this folder, and run |
} | ||
if service.MutatingConfig != nil { | ||
for i := range service.MutatingConfig.Webhooks { | ||
service.MutatingConfig.Webhooks[i].SideEffects = &sideEffect | ||
service.MutatingConfig.Webhooks[i].AdmissionReviewVersions = reviewVersions | ||
service.MutatingConfig.Webhooks[i].ClientConfig = clientConfig | ||
} | ||
|
||
// fix webhook name pattern whether use service or url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// fix webhook name pattern whether use service or url | |
// fix webhook name pattern whether use service or url |
@hwdef can you build in your env? make generate-yaml TAG=latest RELEASE_DIR=installer
mkdir -p _output/bin
mkdir -p installer
/Users/yangyanbo/projects/cetc-cloud/go_project/bin/controller-gen "crd:crdVersions=v1,generateEmbeddedObjectMeta=true" paths="./vendor/volcano.sh/apis/pkg/apis/scheduling/v1beta1;./vendor/volcano.sh/apis/pkg/apis/batch/v1alpha1;./vendor/volcano.sh/apis/pkg/apis/bus/v1alpha1;./vendor/volcano.sh/apis/pkg/apis/nodeinfo/v1alpha1" output:crd:artifacts:config=config/crd/bases
Error: unable to parse option "crd:crdVersions=v1,generateEmbeddedObjectMeta=true": [unknown argument "generateEmbeddedObjectMeta" (at <input>:1:42) extra arguments provided: "true" (at <input>:1:43)]
Usage:
controller-gen [flags]
Examples:
# Generate RBAC manifests and crds for all types under apis/,
# outputting crds to /tmp/crds and everything else to stdout
controller-gen rbac:roleName=<role name> crd paths=./apis/... output:crd:dir=/tmp/crds output:stdout
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Fix issue2102
Signed-off-by: maybaby ybyang7@iflytek.com