change enqueue to optional action #2309
Conversation
Signed-off-by: wpeng102 <wpeng102@126.com>
volcano-sh-bot
added
the
size/S
| @@ -13,6 +13,8 @@ import ( | |||
| "volcano.sh/volcano/pkg/scheduler/api" | |||
| ) | |||
|
|
|||
| var EnqueueExist bool | |||
There was a problem hiding this comment.
Kindly to ask about the reason why hard code enqueue action to make the judgement?
There was a problem hiding this comment.
Introduce ActionMap to store which action is configured by customer.
|
Backgroud: |
pkg/scheduler/conf/scheduler_conf.go
Outdated
| @@ -16,6 +16,9 @@ limitations under the License. | |||
|
|
|||
| package conf | |||
|
|
|||
| // ActionMap check if a action exist in scheduler configmap | |||
| var ActionMap map[string]bool | |||
There was a problem hiding this comment.
Maybe ExistActionMap is better?
There was a problem hiding this comment.
EnabledActionMap is better
| @@ -98,6 +99,10 @@ func (ju *jobUpdater) updateJob(index int) { | |||
| job := ju.jobQueue[index] | |||
| ssn := ju.ssn | |||
|
|
|||
| if !conf.EnabledActionMap["enqueue"] && job.PodGroup.Status.Phase == scheduling.PodGroupPending { | |||
There was a problem hiding this comment.
please add comments here or extract a small func for this special treatment
There was a problem hiding this comment.
add comments for this block
|
Any e2e for scheduler configuration without |
volcano-sh-bot
added
size/L
Add e2e case |
…configmap and add E2E Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
change enqueue to optional action
Signed-off-by: wpeng102 wpeng102@126.com
The enqueue action is a mandatory action right now. It would be wonderful to make it optional and configurable.
Firstly the integration code with other community will be more simple and easy.
Secondly the other actions no need to depend on enqueue . All the actions are decoupled.
#2040
If not config
Enqueueaction, scheduler will change thePendingpg toInqueueat closesession.