Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go.mod to add queue.spec.Affinity #2319

Merged
merged 1 commit into from
Jul 12, 2022
Merged

update go.mod to add queue.spec.Affinity #2319

merged 1 commit into from
Jul 12, 2022

Conversation

qiankunli
Copy link
Contributor

@qiankunli qiankunli commented Jul 1, 2022 •
edited
Loading

I want to support nodegroup in volcano, related pr #2224, which needs to add queue.spec. Affinity field on Queue first, related pr volcano-sh/apis#72
operate history

  1. change version of volcano.sh/apis from v1.5.0-beta.0.0.20220427084719-22d3dd007a8f to v0.0.0-20220705062437-edd428c7d2fd in go.mod, edd428c7d2fd is latest commit of volcano.sh/apis
  2. go mod tidy
  3. go mod vendor
  4. hack/update-gencode.sh
  5. make update-development-yaml

I will continue to push #2224 after the pr is merged.

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 1, 2022
Thor-wl
Thor-wl reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiankunli Please execute go mod vendor to update the dependencies locally and push again.

hwdef
hwdef reviewed Jul 5, 2022
View reviewed changes
go.mod Outdated
stathat.com/c/consistent v1.0.0
volcano.sh/apis v1.5.0-beta.0.0.20220427084719-22d3dd007a8f
volcano.sh/apis v0.0.0-20220630011627-e579d851e770
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The apis has been updated, please synchronize the latest commit number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@qiankunli
Copy link
Contributor Author

@qiankunli Please execute go mod vendor to update the dependencies locally and push again.

updated

[fix]add queue.spec.Affinity
e40ebe6 
Signed-off-by: qiankunli <qiankunli@qq.com>

[fix]add queue.spec.Affinity

Signed-off-by: qiankunli <qiankunli@qq.com>

update apis dependency commit to edd428c7d2fd

Signed-off-by: qiankunli <qiankunli@qq.com>

run go mod vendor

Signed-off-by: qiankunli <qiankunli@qq.com>

run go mod vendor

Signed-off-by: qiankunli <qiankunli@qq.com>
@Thor-wl
Copy link
Contributor

Thor-wl commented Jul 6, 2022

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2022
@william-wang
Copy link
Member

@qiankunli Looks good to me. Please track all releated pr under issue #1830.
It's a good habit to add a subtask and a conresponding pr with it :)

william-wang
william-wang approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@volcano-sh-bot volcano-sh-bot merged commit 292e760 into volcano-sh:master Jul 12, 2022
@qiankunli qiankunli mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thor-wl Thor-wl Thor-wl left review comments

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees

@william-wang william-wang

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiankunli @Thor-wl @william-wang @volcano-sh-bot @hwdef