-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix convertQuanToPercent func #2325
fix convertQuanToPercent func #2325
Conversation
@Thor-wl OK. apiVersion: v1
kind: Pod
...
spec:
containers:
- command:
- sleep
- 10m
image: nginx:latest
imagePullPolicy: Always
name: nginx
resources:
limits:
cpu: "1"
requests:
cpu: "1" Now the task is evicted by rescheduling plugin and I add logs to print the I0702 15:22:54.298356 1 node_utilization_util.go:175] 60.95572916666303 0.015625 Obviously the utilization.utilization[v1.ResourceCPU] -= convertQuanToPercent(v1.ResourceCPU, &usedCPU, utilization.nodeInfo.Status.Capacity) |
Good job! I'm OK about that. Please format the code to pass the code verification and push again. |
Signed-off-by: Tian Qiu <329508111@qq.com>
b0bca98
to
13f823e
Compare
@autumn0207 Can you cherry-pick all the bug fixes to branch release 1.6 as well? I'll launch a bug fix release later. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
the result of func
convertQuanToPercent
needs to be multiplied by 100Signed-off-by: Tian Qiu 329508111@qq.com