add csiNode cache for plugin #2371
Conversation
volcano-sh-bot
added
the
size/M
pkg/scheduler/api/node_info.go
Outdated
| CSINodeName: cs.CSINodeName, | ||
| DriverStatus: make(map[string]bool), | ||
| } | ||
| for k, v := range newcs.DriverStatus { |
There was a problem hiding this comment.
newcs is a empty map. Did you want to loop cs.DriverStatus?
There was a problem hiding this comment.
sorry for code mistake. it should be cs.DriverStatus
Thor-wl
requested review from
hwdef,
qiankunli,
shinytang6 and
william-wang
and removed request for
merryzhou and
alcorj-mizar
| var ok bool | ||
| csiNode, ok = t.Obj.(*sv1.CSINode) | ||
| if !ok { | ||
| utilruntime.HandleError(fmt.Errorf("unable to convert object %T to *sv1.CSINode", obj)) |
There was a problem hiding this comment.
what's the difference between klog and utilruntime.HandleError? if they are the same, we can use the unified format klog and do not have to introcue utiruntime package.
|
@wpeng102 please merge multiple commits to one, thanks :) |
Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com> Signed-off-by: wpeng102 <wpeng102@126.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Signed-off-by: wpeng102 wpeng102@126.com
For internal CSI plugin, it requre scheduler cache maintains a
csiNodesjust likeNodesin cache.