Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the way to build images in makefile #2445

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Aug 18, 2022

Signed-off-by: hwdef hwdefcom@outlook.com

make the makefile consistent with https://github.com/volcano-sh/volcano/blob/master/docs/development/development.md#building-docker-images

before:

make images DOCKER_PLATFORMS="linux/amd64,linux/arm64" BUILDX_OUTPUT_TYPE=registry IMAGE_PREFIX=hwdef

the image tag will be hwdef-controller-manager

after:

make images DOCKER_PLATFORMS="linux/amd64,linux/arm64" BUILDX_OUTPUT_TYPE=registry IMAGE_PREFIX=hwdef

the image tag will be hwdef/vc-controller-manager

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2022
@hwdef
Copy link
Member Author

hwdef commented Aug 18, 2022

/assign @Thor-wl @shinytang6 @Yikun @ccchenjiahuan

@volcano-sh-bot
Copy link
Contributor

@hwdef: GitHub didn't allow me to assign the following users: ccchenjiahuan.

Note that only volcano-sh members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Thor-wl @shinytang6 @Yikun @ccchenjiahuan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: hwdef <hwdefcom@outlook.com>
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2022
Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@volcano-sh-bot volcano-sh-bot merged commit f2c4d7c into volcano-sh:master Aug 18, 2022
@hwdef hwdef deleted the update-makefile branch August 18, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants