Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the setup-go and checkout versions in the action && fix Spark CI #2938

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

wangyang0616
Copy link
Member

@wangyang0616 wangyang0616 commented Jun 26, 2023

Run CI code verify, and often encounter errors when installing go through action/setup-go@v2. I don’t know the reason for now.

node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: EEXIST: file already exists, mkdir '/home/runner/work/volcano-sh/volcano'] {
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/home/runner/work/volcano-sh/volcano'
}

I checked set-go/tags and the latest version is v4. You can try to upgrade the latest version to see if it can solve the current problem.


The current pr repairs the CI of Code Verify , but E2E Spark Integration Test CI will still report an error;
#2934 repaired E2E Spark Integration Test CI, but Code Verify CI will report an error

Cherry-pick the submission of #2934 to the current pr, fix the CI problem together, and avoid the deadlock between the two prs.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2023
Signed-off-by: wangyang <wangyang8126@gmail.com>
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2023
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@wangyang0616 wangyang0616 changed the title Upgrade the setup-go and checkout versions in the action Upgrade the setup-go and checkout versions in the action && fix Spark CI Jun 27, 2023
@Yikun
Copy link
Member

Yikun commented Jun 27, 2023

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang, Yikun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@volcano-sh-bot volcano-sh-bot merged commit f5a0562 into volcano-sh:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants