Optimize the jobflow architecture design diagram #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
wangyang0616
force-pushed
the
jobflow_design_doc
branch
from
f4a7c07
to
992cd67
Compare
Thor-wl
requested review from
william-wang,
hwdef and
Thor-wl
and removed request for
qiankunli and
jiangkaihua
Thor-wl
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
@wangyang0616 Thanks for your hard work! The new architecture turns to be more clear than the older ones. They not only highlight the added compontents but also mark the resource relationship.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
volcano-sh-bot
added
the
do-not-merge/hold
hwdef
reviewed
Aug 1, 2023
docs/design/jobflow/README.md
Outdated
|  | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Suggested change
|  | |
|  |
docs/design/jobflow/README.md
Outdated
| @@ -58,7 +56,7 @@ Deleting a jobflow when the jobflow is in a non-complete state will be intercept | |||
|
|
|||
| ### Controller | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
Suggested change
|  | |
|  |
…rly and concisely Signed-off-by: wangyang <wangyang8126@gmail.com>
wangyang0616
force-pushed
the
jobflow_design_doc
branch
from
992cd67
to
ae3c9b3
Compare
volcano-sh-bot
removed
the
do-not-merge/hold
william-wang
reviewed
Aug 2, 2023
|  | ||
|
|
||
| The blue part is the component of k8s itself, the green and brown are the components of volcano, and the yellow is the crd resource of volcano. | ||
| The blue part is the components of k8s itself, the orange is the existing definition of Volcano, and the red is the new definition of JobFlow. |
There was a problem hiding this comment.
please update the description. It is out of date after refreshing the jobflow-2.jpg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt a more concise color scheme and optimize the color and style of the architecture diagram.