Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick for release-1.8] msg information optimization; preemption logic optimization #3082

Merged

Conversation

lowang-bh and others added 4 commits August 28, 2023 10:40
Signed-off-by: lowang-bh <lhui_wang@163.com>
1. improve performance
2. fix the pod messages has many ','

Signed-off-by: lowang-bh <lhui_wang@163.com>
succeed predicated node has empty reason, and joined string will has empty string between ','

Signed-off-by: lowang-bh <lhui_wang@163.com>
…t does not support preemption by strategies such as antiAffinity and topologyspread

Signed-off-by: wangyang <wangyang8126@gmail.com>
@wangyang0616 wangyang0616 changed the base branch from master to release-1.8 August 28, 2023 02:48
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2023
@wangyang0616 wangyang0616 reopened this Aug 28, 2023
…The status is not updated when the pod group does not change.

Signed-off-by: wangyang <wangyang8126@gmail.com>
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@volcano-sh-bot volcano-sh-bot merged commit 579c719 into volcano-sh:release-1.8 Aug 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants