Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic when get job's elastic resource #3106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix panic when get job's elastic resource #3106

wants to merge 2 commits into from

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Sep 8, 2023 •
edited
Loading

Fix: #3105 (scheduler panic when calculate the elastic resource) via first commit
Fix: #3127 (panic when guarantee greater than allocatable resource) via second commit

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2023
@lowang-bh lowang-bh force-pushed the fixIssue branch 2 times, most recently from b9b1afb to cb77851 Compare September 9, 2023 01:38
@lowang-bh lowang-bh mentioned this pull request Sep 17, 2023
Closed
@lowang-bh lowang-bh mentioned this pull request Nov 25, 2023
Open
@lowang-bh
Copy link
Member Author

/assign @Monokaix

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign lowang-bh
You can assign the PR to them by writing /assign @lowang-bh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@lowang-bh
Copy link
Member Author

/priority important-soon

@volcano-sh-bot volcano-sh-bot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 13, 2024
@lowang-bh lowang-bh mentioned this pull request Sep 9, 2024
Open
@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2024
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@hwdef
Copy link
Member

hwdef commented Oct 9, 2024

Does the capacity plugin need to be handled?

@lowang-bh
fix panic when get job's elastic resource
9a1bcc6 
Signed-off-by: lowang-bh <lhui_wang@163.com>
@lowang-bh
fix panic when sub total guarantee
1cba5c3 
Signed-off-by: lowang-bh <lhui_wang@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Monokaix left review comments

@hudson741 hudson741 Awaiting requested review from hudson741

@william-wang william-wang Awaiting requested review from william-wang

At least 1 approving review is required to merge this pull request.

Assignees

@Monokaix Monokaix

Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@lowang-bh @volcano-sh-bot @hwdef @Monokaix