fix: the pod anti-affinity constraint fails #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
wangyang0616
force-pushed
the
add_podaffinity_logs
branch
2 times, most recently
from
74aecf9 to
cc6a275
Compare
wangyang0616
force-pushed
the
add_podaffinity_logs
branch
from
cc6a275 to
ba31856
Compare
| if VGPUEnable { | ||
| fit, _, err := checkNodeGPUSharingPredicate(pod, gs, true) | ||
| if err != nil || !fit { | ||
| klog.Errorln("deviceSharing err=", err.Error()) | ||
| return devices.Unschedulable, fmt.Sprintf("4pdvgpuDeviceSharing %s", err.Error()), err | ||
| } | ||
| } | ||
| klog.V(3).Infoln("4pdvgpu DeviceSharing:FitInPod successed") | ||
| klog.V(5).Infoln("4pdvgpu DeviceSharing:FitInPod successed") |
There was a problem hiding this comment.
update this message to make more clear for user. change the 4pdvgpu and make the message to be a complete sentence.
| skipPlugins[taskKey] = plugins | ||
| } | ||
| skipPlugins[taskKey].Insert(interpodaffinity.Name) | ||
| klog.V(3).Infof("pod(%s/%s) affinity require information is nil, plugin InterPodAffinity is skip", |
There was a problem hiding this comment.
change "pod(%s/%s) affinity require information is nil, plugin InterPodAffinity is skip" to "pod(%s/%s) affinity require information is nil, plugin InterPodAffinity is skipped."
…sed on the pod information Signed-off-by: wangyang0616 <wangyang8126@gmail.com>
Signed-off-by: wangyang0616 <wangyang8126@gmail.com>
wangyang0616
force-pushed
the
add_podaffinity_logs
branch
from
ba31856 to
a324fa6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3138
Volcano schedules multiple pods in batches in a session. You need to record which filter policies need to be skipped for the key value of the pod. Otherwise, pods may affect each other.