fix: allocated field in queue status is calcutated error #3199
Conversation
|
Welcome @shusley244! |
volcano-sh-bot
added
the
size/XS
|
/assign @william-wang @shinytang6 |
|
/lgtm Is there any test results? |
@lowang-bh yes, I applied the change to my prod environment one month ago, everything is fine. |
…which status in bound, binding, allocated and running Signed-off-by: qianjiajun <244058785@qq.com>
|
@lowang-bh can you review again ? I fixed the dco check. |
|
/lgtm |
|
@k82cn @william-wang @hwdef |
|
@shusley244 Thanks for your contribution. please cherry-pick this pr to release-1.8 branch. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowang-bh, william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
ok, thanks for your approve. FOSSA action failed, can you retry it? or I will close this pr when new pr is approved~ new pr: #3221 |
|
/close |
|
@Monokaix: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The allocated field in the queue status should be calculated based on tasks with the status "bound", "binding", "allocated", and "running".
If the container is slow to be running status (such as stuck on image pull stage), we can't obtain the correct value for the allocated field from the queue status even if volcano is finished to scheduler the task.