add mock cache for ut and performance test #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/L
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lowang-bh
force-pushed
the
mockSchedulerCache
branch
3 times, most recently
from
25b3d2f
to
5a01c18
Compare
This was referenced Dec 17, 2023
|
/assign @Monokaix @wangyang0616 @william-wang |
lowang-bh
force-pushed
the
mockSchedulerCache
branch
from
5a01c18
to
203f8b5
Compare
Monokaix
reviewed
Jan 4, 2024
Monokaix
reviewed
Jan 4, 2024
|
Hi, please resolve code conflict. |
lowang-bh
force-pushed
the
mockSchedulerCache
branch
3 times, most recently
from
aadbf47
to
d234439
Compare
|
/lgtm |
|
/assign @william-wang |
Signed-off-by: lowang-bh <lhui_wang@163.com>
lowang-bh
force-pushed
the
mockSchedulerCache
branch
from
d234439
to
cf51c87
Compare
|
/assign @Monokaix @hwdef @wangyang0616 @william-wang |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr supply mock SchedulerCache with two methods:
NewCustomMockSchedulerCacheuse customer's interface to replace those schedulerCache's interfaceNewDefaultMockSchedulerCacheuse k8s fake client as the default one to replace schedulerCache's interface.we can use mockSchedulerCache in this PR to do those things:
performance UT test in issue Performance benchmark is need #3244
Improve all UTs such as: