-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vcctl jobflow command #3543
Conversation
c326d09
to
502a7cf
Compare
502a7cf
to
bb99079
Compare
48c1be2
to
2005ab7
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @william-wang /PTAL |
} | ||
|
||
jobFlowClient := versioned.NewForConfigOrDie(config) | ||
jobFlow, err := jobFlowClient.FlowV1alpha1().JobFlows(getJobFlowFlags.Namespace).Get(ctx, getJobFlowFlags.Name, metav1.GetOptions{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If getJobFlowFlags.Namespace
== "", it will return all jobflow, we should set a default ns here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have default value.
// InitGetFlags is used to init all flags.
func InitGetFlags(cmd *cobra.Command) {
util.InitFlags(cmd, &getJobFlowFlags.CommonFlags)
cmd.Flags().StringVarP(&getJobFlowFlags.Name, "name", "N", "", "the name of jobflow")
cmd.Flags().StringVarP(&getJobFlowFlags.Namespace, "namespace", "n", "default", "the namespace of jobflow")
}
2005ab7
to
6986207
Compare
8cc64d8
to
399aa5f
Compare
/lgtm |
@googs1025 Please add the vcctl jobflow command line to the design doc:) |
pr here: #3584 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef, william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: googs1025 <googs1025@gmail.com>
399aa5f
to
93b6e71
Compare
@Monokaix /PTAL lgtm label for appove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
-f
(file) to pass in yaml file to create jobflow resource-f
(file) to pass in yaml file to delete jobflow resource or-N
(name)-n
(namespace) to delete jobflow resource-o, --format
to output in yaml or json format,-N
(name)-n
(namespace) to inquire-n
(namespace) to inquire , and--all-namespaces
to list jobflows in all namespaces-N
(name)-n
(namespace) to inquireWhich issue(s) this PR fixes:
Fixes #3495
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Added vcctl jobflow command feature
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None