-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: use milliseconds instead of microseconds as the time unit for scheduling latency #3548
Conversation
Welcome @microyahoo! |
…r scheduling latency The current time unit cannot accurately reflect the actual scheduling time like below ``` volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="5"} 0 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="10"} 0 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="20"} 0 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="40"} 0 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="80"} 0 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="160"} 0 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="320"} 1 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="640"} 1 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="1280"} 68550 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="2560"} 198253 volcano_action_scheduling_latency_microseconds_bucket{action="allocate",le="+Inf"} 243524 volcano_action_scheduling_latency_microseconds_sum{action="allocate"} 5.505664439029926e+08 ``` Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
Shall we mark it deprecated first and then remove it after several releases? |
hi @lowang-bh, thanks for your quick response. There is also another workaround that doesn't introduce a breaking change; we just need to modify the exponential bucket count to cover a wider range. |
@Monokaix please take a look. |
What's the problem of using microseconds? |
hi @Vacant2333, if microseconds are used, the maximum range of the bucket is 2.56ms. Values greater than 2.56ms will all fall into this bucket, which does not reflect the actual scheduling latency. |
I want to know how you @mentioned me; I have no connection to this PR. |
I think he's pointing me: ) |
/lgtm |
sorry, my mistake @Vacant2333 |
hi @lowang-bh @hudson741 @Thor-wl, PTAL, thanks. |
/lgtm |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The current time unit cannot accurately reflect the actual scheduling time like below
Signed-off-by: Liang Zheng zhengliang0901@gmail.com